Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default opsz value should not be elided #3213

Open
RosaWagner opened this issue Mar 23, 2021 · 0 comments
Open

Default opsz value should not be elided #3213

RosaWagner opened this issue Mar 23, 2021 · 0 comments
Assignees
@m4rc1e
Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id P0 Urgent
Milestone
Leftover from lat...

Comments

@RosaWagner
Copy link
Contributor

following on this : googlefonts/gf-docs#83 (comment)

opsz fallback should not be elided.

Reasons:

  • to not break ordering in font menu
  • to make obvious which optical size is the default one (if it is elided, it is not explicit anymore)
@RosaWagner RosaWagner added P0 Urgent New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id labels Mar 23, 2021
@RosaWagner RosaWagner changed the title [new check] default opsz value should not be elided Default opsz value should not be elided Mar 23, 2021
@aaronbell aaronbell mentioned this issue Jun 29, 2021
Closed
@RosaWagner RosaWagner added this to the 0.8.11 milestone Jul 1, 2022
@felipesanches felipesanches modified the milestones: 0.8.11, 0.8.12 Aug 19, 2022
@felipesanches felipesanches modified the milestones: 0.8.12, 0.8.14 Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m4rc1e m4rc1e

Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id P0 Urgent
Projects
None yet
Milestone
Leftover from latest dev-cycle
Development

No branches or pull requests
3 participants
@felipesanches @m4rc1e @RosaWagner