Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: commit confirm window in neogit shows nothing #388

Closed
3 tasks done
TroySigX opened this issue Mar 10, 2023 · 8 comments
Closed
3 tasks done

bug: commit confirm window in neogit shows nothing #388

TroySigX opened this issue Mar 10, 2023 · 8 comments
Labels
bug Something isn't working stale

Comments

@TroySigX
Copy link

TroySigX commented Mar 10, 2023

Did you check docs and existing issues?

  • I have read all the noice.nvim docs
  • I have searched the existing issues of noice.nvim
  • I have searched the exsiting issues of plugins related to this issue

Neovim version (nvim -v)

0.8.3

Operating system/version

6.2.2-arch1-1

Describe the bug

When the commit confirm window of neogit shows up, it was blank.
image

Steps To Reproduce

  1. commit something in neogit
  2. :wq
  3. Confirm window pops up and it shows nothing

Expected Behavior

Yes and no options should appear on the window.

@TroySigX TroySigX added the bug Something isn't working label Mar 10, 2023
@max397574
Copy link
Contributor

could you please provide a repro

@TroySigX
Copy link
Author

TroySigX commented Mar 10, 2023

Here is my config:

local lazypath = vim.fn.stdpath('data') .. '/lazy/lazy.nvim'
if not vim.loop.fs_stat(lazypath) then
    vim.fn.system({
        'git',
        'clone',
        '--filter=blob:none',
        'https://github.com/folke/lazy.nvim.git',
        '--branch=stable',
        lazypath,
    })
end
vim.opt.rtp:prepend(lazypath)

require('lazy').setup({
    {
        'TimUntersberger/neogit',
        dependencies = {
            'sindrets/diffview.nvim',
            'nvim-lua/plenary.nvim'
        },
        config = function()
            require('neogit').setup {
                disable_signs = false,
                disable_hint = false,
                disable_context_highlighting = false,
                disable_commit_confirmation = false,
                auto_refresh = true,
                disable_builtin_notifications = false,
                use_magit_keybindings = false,
                kind = "tab",
                console_timeout = 2000,
                auto_show_console = true,
                popup = {
                    kind = "vsplit",
                },
                signs = {
                    -- { CLOSED, OPENED }
                    section = { ">", "v" },
                    item = { ">", "v" },
                    hunk = { "", "" },
                },
                integrations = {
                    diffview = true
                },
                sections = {
                    untracked = {
                        folded = false
                    },
                    unstaged = {
                        folded = false
                    },
                    staged = {
                        folded = false
                    },
                    stashes = {
                        folded = true
                    },
                    unpulled = {
                        folded = true
                    },
                    unmerged = {
                        folded = false
                    },
                    recent = {
                        folded = true
                    },
                },
            }
        end,
    },
    {
        'folke/noice.nvim',
        dependencies = {
            'MunifTanjim/nui.nvim',
        },
        config = function()
            require('noice').setup({
                cmdline = {
                    view = 'cmdline',
                },
                lsp = {
                    override = {
                        ['vim.lsp.util.convert_input_to_markdown_lines'] = true,
                        ['vim.lsp.util.stylize_markdown'] = true,
                        ['cmp.entry.get_documentation'] = true,
                    },
                },
                presets = {
                    bottom_search = true,
                    command_palette = false,
                    long_message_to_split = true,
                    inc_rename = true,
                    lsp_doc_border = false,
                },
            })
        end,
    },
})

@TroySigX
Copy link
Author

Hi, is there any update on this?

@folke
Copy link
Owner

folke commented Apr 23, 2023

It you want to look into this or create a pr, go ahead. I don't use neogit, so not planning to look into this.

@TroySigX
Copy link
Author

I dont know how to do it, can anyone please help?

@vandalt
Copy link

vandalt commented May 22, 2023

I think this is a duplicate of #232, which is fixed by NeogitOrg/neogit#441. As mentioned there, you can use disable_commit_confirmation = true in the meantime, so the pop-up won't appear at all.

@TroySigX
Copy link
Author

Thanks @vandalt !

sohooo pushed a commit to sohooo/nvim that referenced this issue May 23, 2023
Copy link
Contributor

github-actions bot commented Jul 6, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Jul 6, 2024
@TroySigX TroySigX closed this as completed Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

4 participants