Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--from argument is required #18

Open
DavidTheProgrammer opened this issue May 21, 2017 · 6 comments
Open

--from argument is required #18

DavidTheProgrammer opened this issue May 21, 2017 · 6 comments

Comments

@DavidTheProgrammer
Copy link

I'm running the command right, at lease I'd like to think so, but the response is always the same

the --from argument is required

The command I'm running is:

readmegen --from v0.0.0-alpha --release v0.0.0-alpha0.1

I even tried renaming my tags and removing the "v" prefix but that hasn't helped either.

@o-shabashov
Copy link

Hm, strange, its work for me. I've did clear install, this repo and my fork - both work great.
What shell you use?

@gilbertopineda
Copy link

Replace break; to continue; in ulrichsg\getopt-php\src\Ulrichsg\Getopt\CommandLineParser.php line 47. It works for me.

@DavidTheProgrammer
Copy link
Author

Thanks for the responses, but I fixed it. Just didn't have the time yet to post the answer. Turns out it wasn't reading the command line arguments properly because my PHP Installation didn't have the mbstring() method. A quick install of that package fixed everything.

Strange thing is though, I have another problem. The readmegen.yml file is not being parsed properly, The default keywords are being ignored unless I add some different from the defaults. It's the only way it works, I don't know why. My readmegen.yml now looks like this:

vcs: git
format: md
break: "## Changelog"
output_file_name: "CHANGELOG.md"
message_groups:
  New:
    - new
  Squashed Bugs:
    - bug
  Docs:
    - doc
  Code Refactors:
    - ref
  Minor:
    - minor 

Anybody else encountering this problem?

@fojuth
Copy link
Owner

fojuth commented May 29, 2017

Hey, sorry for replying so late :/ Didn't have much time lately.

@DavidTheProgrammer glad you found the solution to the problem you encountered! :)

About the second issue - this looks strange. I didn't get any reports about that earlier. Did you do some debugging inside the Extractor which is responsible for gathering the message groups (/vendor/fojuth/readmegen/src/Log/Extractor.php)? The setMessageGroups() method might give some answers.

Let me know if you solved the problem or if it still persists.

@DavidTheProgrammer
Copy link
Author

@fojuth I can't for the life of me figure it out. Looked at the recommended file but I can't make heads or tails of it, I'm not a PHP programmer, mostly JS. I can see what is supposed to be happening but I can't make a proper stack trace to locate the issue.

Am I the only one experiencing this issue though?

@fojuth
Copy link
Owner

fojuth commented May 30, 2017

I didn't get any other report about the issue you encountered, sorry :( I can't reproduce it, so I won't be much of help. Should you have more info about the bug - please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants