Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add support for F13-F24 keys for keybindings #436

Open
DSVDiniz opened this issue Oct 3, 2024 · 12 comments
Open

Feature Request: Add support for F13-F24 keys for keybindings #436

DSVDiniz opened this issue Oct 3, 2024 · 12 comments

Comments

@DSVDiniz
Copy link

DSVDiniz commented Oct 3, 2024

I use a keyboard with custom macro keys that use the old F13-F24 keys, maybe I'm just an outlier but this would help me out greatly.

@focus-editor focus-editor added this to the 0.3.8 milestone Oct 3, 2024
@focus-editor
Copy link
Owner

What OS are you on? We'd like to ask you to test a build to make sure it's correct

@DSVDiniz
Copy link
Author

DSVDiniz commented Oct 3, 2024

OS: Kubuntu 22.04.4 LTS x86_64

@focus-editor
Copy link
Owner

Please download a nightly build from here and check that it works, thanks https://ileonte.dev/focus-builds/Linux/nightly/focus-linux-nightly-2c2a748

@DSVDiniz
Copy link
Author

DSVDiniz commented Oct 3, 2024

image
I've tried all my macro keys and it's not working.
I also tested on VSCode and this site just to be sure and they're working fine.

@focus-editor
Copy link
Owner

Thanks, will fix and will send you another build later

@focus-editor
Copy link
Owner

focus-editor commented Oct 19, 2024

Sorry for taking this long, had a busy 2 weeks.

When you were testing this, did the keys F1-F16 work, or was it only F1-F12?

When you have a moment, please try the latest build from here when it builds https://ileonte.dev/focus-builds/Linux/nightly/
(must be after the one at 2024-Oct-19 20:07)

@DSVDiniz
Copy link
Author

Tested it again on focus-linux-nightly-45b31c2, F1-F12 work fine, F13-F24 do not.

@DSVDiniz
Copy link
Author

I was testing the same feature in raylib, keycodes for f13-f24 are the following:
KeyF13 = 302
KeyF14 = 303
KeyF15 = 304
KeyF16 = 305
KeyF17 = 306
KeyF18 = 307
KeyF19 = 308
KeyF20 = 309
KeyF21 = 310
KeyF22 = 311
KeyF23 = 312
KeyF24 = 313
Don't know if this helps.

@focus-editor
Copy link
Owner

This is what we have for those keys

XK_F13 :: 0xffca;

@focus-editor
Copy link
Owner

Someone with Linux knowledge will need to look at this. It's hard to debug this without a proper keyboard and a proper OS.

Please follow up on Discord if it gets neglected for too long.

@ileonte
Copy link
Collaborator

ileonte commented Nov 3, 2024

I'm looking at fixing this but I don't have a keyboard that can generate F13-F24 so I'm going to have to make some guesses here. Before I do that, @DSVDiniz can I please ask you to test if running with the XCB backend makes any difference for you? From a terminal run:

FOCUS_LD_BACKEND=xcb /path/to/focus

(you may need to install some extra packages on Ubuntu 22.04, if you need any help with that let me know)

@focus-editor focus-editor removed this from the 0.3.8 milestone Dec 7, 2024
@focus-editor
Copy link
Owner

Looks like this is getting delayed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants