Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pytest dependency to more modern version #138

Open
jaywon opened this issue Jun 1, 2023 · 2 comments
Open

Upgrade pytest dependency to more modern version #138

jaywon opened this issue Jun 1, 2023 · 2 comments

Comments

@jaywon
Copy link

jaywon commented Jun 1, 2023

I have a current issue where a project I'm trying to deploy in a function has a valid dependency requirement for a more recent version range of pytest which is not compatible with the pinned version in fdk-python ([email protected]). The current pytest release is 7.3.1.

If I understand correctly pytest is also not a core dependency for fdk-python but supports the unit tests capability.

  1. Can pytest version be safely upgraded in the project to something more modern?
  2. Can pytest be a development dependency and not a required dependency since it's really not a "production" release requirement of a function.
@denismakogon
Copy link
Member

As a maintainer of this lib in the past, I can say that - sure, no issues. Submit the PR and I let the team aware of it.

@AndrewFrideres13
Copy link

Any progress on this? Would be quite nice to either have it upgraded, or ideally, marked properly as a dev dependency for fdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants