Added support for modern vg_ and fg_ variables in vlsvextract for rotation and plasma frame #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed hard-coded proton to use popName for plasma frame shift. |
|
So I tested this with an EGI bulk and an EGI restart, works. The only thing that might be confusing to the user is that it prints a VLSV failed message for each unsuccessful read attempt. But in case of success it prints that too and if all fail there is a proper error printed followed by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the can. A fix for #688.
Querying fg_b would require quite a bit more code (parsing fsgrid etc). Though now that I think of it, we can't rotate or shift for restarts with this either.