Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "benches" branch #86

Open
omid opened this issue Oct 5, 2022 · 3 comments
Open

The "benches" branch #86

omid opened this issue Oct 5, 2022 · 3 comments

Comments

@omid
Copy link
Collaborator

omid commented Oct 5, 2022

Hello @fmeringdal :)

Any plan on finishing/merging https://github.com/fmeringdal/rust-rrule/tree/feat/benches branch?

@fmeringdal
Copy link
Owner

Not in the near future. Is it something you need or want to work on? :)

@omid
Copy link
Collaborator Author

omid commented Oct 5, 2022

It's something I need.
I actually wanted to think and maybe start #67 ticket, but without a benchmark, it doesn't make sense.

@fmeringdal
Copy link
Owner

I see. Unfortunately, I wont have time to add a benchmarking suite to the repo in the near future.
Feel free to implement #67 if you want to, probably won't be able to measure a statistical speedup, but maybe flamegraph can give hints that the library is spending less time on string operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants