This repository has been archived by the owner on Aug 6, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 62
Multi-domain (server configuration) support for caldav, carddav and imap. #181
Open
dh-programacion
wants to merge
229
commits into
fmbiete:master
Choose a base branch
from
dinahosting:multi-domain-backends
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Multi-domain (server configuration) support for caldav, carddav and imap. #181
dh-programacion
wants to merge
229
commits into
fmbiete:master
from
dinahosting:multi-domain-backends
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oincidents names. That's a bad idea, but this will workaround it
…icrosoft.com. Issue fmbiete#56
…fications. Reminders are not yet implemented and DiffBackend doesn't support MeetingResponses so it's not really useful
…re showing broken messages and missing attachments
…e first is the preferred
Fix caldav default calendar/task handling We were missing some ' in the defined function calls
Wherever counts are shown, the number should not be quoted. This might seem to indicate that it's a string we're showing. Also add logging location to Sync logging of incoming changes.
Signed-off-by: Francisco Miguel Biete <[email protected]> <[email protected]>
Bring code closer to original Mail_mimeDecode
pull request... -100 points to me Signed-off-by: Francisco Miguel Biete <[email protected]> <[email protected]>
CalDAVClient improvements
Improve logging output for counts
Don't use imap_getsubscribed since won't return INBOX in dovecot. Should fix fmbiete#157. There are new required config options. If don't configured BackendIMAP will refuse to work at all. Signed-off-by: Francisco Miguel Biete <[email protected]> <[email protected]>
Thanks @normk2k! Signed-off-by: Francisco Miguel Biete <[email protected]> <[email protected]>
Signed-off-by: Francisco Miguel Biete <[email protected]> <[email protected]>
Showed as special folders in iOS devices. Thanks to Javier Achirica by the patch.
Thanks to Javier Achirica!
Signed-off-by: Francisco Miguel Biete <[email protected]> <[email protected]>
decoded before parsing and validate them. Fixes fmbiete#164 Signed-off-by: Francisco Miguel Biete <[email protected]> <[email protected]>
Signed-off-by: Francisco Miguel Biete <[email protected]> <[email protected]>
Signed-off-by: Francisco Miguel Biete <[email protected]> <[email protected]>
we won't have all the environment variables loaded Signed-off-by: Francisco Miguel Biete <[email protected]>
moving to Trash. Signed-off-by: Francisco Miguel Biete <[email protected]> <[email protected]>
PHP 5.6 has changed the default behaviour, and will verify the certificates by default. Signed-off-by: Francisco Miguel Biete <[email protected]> <[email protected]>
… find the Send folder Signed-off-by: Francisco Miguel Biete <[email protected]> <[email protected]>
Signed-off-by: Francisco Miguel Biete <[email protected]> <[email protected]>
…apId Signed-off-by: Francisco Miguel Biete <[email protected]> <[email protected]>
Add a Gitter chat badge to README.md I'm not sure this will be useful, or it will be an eternal empty room 😆
Thanks @pfitseng Signed-off-by: Francisco Miguel Biete <[email protected]> <[email protected]>
…map. Initial release
Hello! Regards |
$this->_caldav = new CalDAVClient(CALDAV_SERVER . ":" . CALDAV_PORT . $this->_caldav_path, $username, $password); | ||
|
||
// If domain is empty we use username's domain | ||
$domain_replace = ( $domain ) ? $domain : explode('@', $username,2)[1]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If $username doesn't contains '@' this will fail. For example, with the default config (USE_FULLEMAIL_FOR_LOGIN = false), or if the username doesn't contain the domain part (single domain server).
You should check if it contains '@', so it could be reduced to this:
strpos($domain, '@') === false ? $domain : explode('@', $username, 2)[1];
cool thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for multiple providers in backends: