-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple URLs with the same identities cause duplicated recipients in age encrypted secrets #437
Comments
I'm not sure how to de-duplicate public-keys while also making sure that both properties are preserved. |
So, perhaps I'm missing some context or not seeing a case you have in mind, but: what's wrong with only notifying if there's an actual change? I.e. only if one key was actually added or removed rather than duplicated or deduplicated? If a member was added/removed to/from a RG (I've only used it with the keys feature of my.flyingcircus.io so far) it doesn't seem too interesting to me unless I now encrypt the secrets for someone new or someone loses access to the secrets from now on. |
Just noticed that the |
Looking into this since this obviously interferes with the usecase of having the keys in a lockfile |
Consider secret config like this:
Now, if I'm allowed to log into both RGs, there are two recipients with the same ssh key.
My expectation would be that for each user, only one recipient is added to age_keys.txt.
It's not a big deal in practice, but still a little odd.
The text was updated successfully, but these errors were encountered: