Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hooks to run before and after the popup appear #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lthms
Copy link

@lthms lthms commented Jul 29, 2022

This is a simple proposal to have a way to run custom code when the popup is created and when it is deleted.

Here is how I use it:

(use-package eldoc-box
  :hook
  (eldoc-mode . eldoc-box-hover-at-point-mode)
  (flycheck-popup-tip-show . (lambda ()
                               (when eldoc-box-hover-at-point-mode
                                 (eldoc-box-hover-at-point-mode -1))))
  (flycheck-popup-tip-delete . (lambda ()
                                 (unless eldoc-box-hover-at-point-mode
                                   (eldoc-box-hover-at-point-mode)))))

Thanks to that, there is no conflict anymore between eldoc-box and flycheck-popup-tip.

Feel free to merge or close this PR, as you see fit.

Thanks for flycheck-popup-tip.

@CLAassistant
Copy link

CLAassistant commented Jul 29, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants