Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Close AppBar when tap #124

Merged
merged 1 commit into from
Mar 14, 2022
Merged

fix Close AppBar when tap #124

merged 1 commit into from
Mar 14, 2022

Conversation

furkanolkay
Copy link
Contributor

Fix #120

I fixed 2 todo.

I wrap the menu focus, I got it to turn off on non-menu clicks and also when choosing from the menu.
close-appbar

@bgoktugozdemir bgoktugozdemir self-requested a review March 14, 2022 08:27
@bgoktugozdemir
Copy link
Member

Hi Furkan, thank you for your contribution.

I had a little question. Can you answer that?

@furkanolkay
Copy link
Contributor Author

Hi Furkan, thank you for your contribution.

I had a little question. Can you answer that?

Of course, what's the question?

@bgoktugozdemir
Copy link
Member

bgoktugozdemir commented Mar 14, 2022 •
edited
Loading

Hi Furkan, thank you for your contribution.
I had a little question. Can you answer that?

Of course, what's the question?

I asked it below.

bgoktugozdemir
bgoktugozdemir approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@bgoktugozdemir bgoktugozdemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Great work. Thank you for your valuable contribution.

lib/navigation/ui/website_navigation.dart Show resolved Hide resolved
@bgoktugozdemir bgoktugozdemir merged commit 4c8ae83 into flutterturkey:main Mar 14, 2022
@furkanolkay furkanolkay deleted the bugfix/FTW-120-close-appbar-when-tap branch March 14, 2022 17:51
@furkanolkay
Copy link
Contributor Author

Hello, I saw when the code went live, focusNode does not work as I expected in the mobile version.
I tried it as web in Responsive, it was not enough.
You can reopen a task to have it closed on non-menu clicks.😕

@bgoktugozdemir
Copy link
Member

Hello, I saw when the code went live, focusNode does not work as I expected in the mobile version.
I tried it as web in Responsive, it was not enough.
You can reopen a task to have it closed on non-menu clicks.😕

Sure. I reopened this issue again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgoktugozdemir bgoktugozdemir bgoktugozdemir approved these changes

Assignees

@furkanolkay furkanolkay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Close AppBar when tap
2 participants
@furkanolkay @bgoktugozdemir