Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevTools 2.40.1 Cherry Pick Release #8415

Open
kenzieschmoll opened this issue Oct 8, 2024 · 0 comments
Open

DevTools 2.40.1 Cherry Pick Release #8415

kenzieschmoll opened this issue Oct 8, 2024 · 0 comments
Assignees
@kenzieschmoll
Labels
P0 critical issue (e.g. build break, regression, blocker for top-tier customer, critical tech debt)

Comments

@kenzieschmoll
Copy link
Member

kenzieschmoll commented Oct 8, 2024 •
edited
Loading

A cp release is needed because DevTools 2.40.0 was built with a version of flutter that included a skwasm renderer bug (causing #8401).

This rendering issue was fixed by this revert: flutter/engine#55715. When this commit rolls into the flutter framework, a DevTools cherry pick release will need to be performed from a Flutter framework version that includes the before mentioned Flutter engine revert commit. This Flutter framework hash must be used in the flutter-candidate.txt file.

The DevTools CP release should include:

  • The flutter-candidate.txt update to include the Flutter engine fix: d369b4f

Since a CP release has to be done anyway, we will also include a couple of bug fixes:

  • Fix a bug causing an opened dialog to put the DevTools navigator in an unrecoverable state: 7c8b217
  • Fix an issue with the Inspector V2 experiment causing the details tab selection to be lost when changing selected widgets: 8120227
  • Fix an issue with filters being reset upon clearing data: 2603615

Once the CP release is complete, the DevTools release notes on the Flutter website should be updated for version 2.40.1.
@kenzieschmoll kenzieschmoll self-assigned this Oct 8, 2024
@kenzieschmoll kenzieschmoll added the P0 critical issue (e.g. build break, regression, blocker for top-tier customer, critical tech debt) label Oct 8, 2024
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 8, 2024
@kenzieschmoll
[main] Release DevTools 2.40.1
edbeda7 
Bug: flutter/devtools#8415
Change-Id: I7b33f6bf93d1010512c59f3857d8477bc8a8d398
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388742
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Kenzie Davisson <[email protected]>
@kenzieschmoll kenzieschmoll mentioned this issue Oct 8, 2024
Open
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 9, 2024
@kenzieschmoll
[beta] Cherry pick DevTools 2.40.1 into the SDK beta branch.
685f736 
This CP is targeting the Flutter 3.27 beta release. This resolves bugs
with the skwasm renderer for DevTools and fixes a couple of other bugs.
See flutter/devtools#8415.

Bug: #56870
Change-Id: I1b4fab7588c603b25f63450c6dbeeea05585d7b1
Cherry-pick: flutter/devtools@v2.40.0...2.40.1
Cherry-pick-request: #56870
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388944
Reviewed-by: Alexander Thomas <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kenzieschmoll kenzieschmoll

Labels
P0 critical issue (e.g. build break, regression, blocker for top-tier customer, critical tech debt)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kenzieschmoll