Additional invites or updates don't send the correct RTMAP

[reduxdj]

Describe the bug
After an initial invite the server responds with an rtmap of the supported candidates... but the library does not honor these, instead of sending an intersection of the rtmap from the ones the supported, all future invites keep sending the whole list which has a the potential of not working with some SIP carriers

SIP/2.0 200 OK
Via:
From:
To:
Call-ID: 0m70b41666e5072839r7
CSeq: 8489 INVITE
Contact: sips:XXX:19306;transport=wss
Allow: OPTIONS, REGISTER, SUBSCRIBE, NOTIFY, PUBLISH, INVITE, ACK, BYE, CANCEL, UPDATE, PRACK, MESSAGE, REFER
Supported: 100rel, timer, replaces, norefersub
Content-Type: application/sdp
Content-Length: 625

v=0
o=- 183420937 4 IN IP4 172.18.121.173
s=edifylabs-vapi-v2
c=IN IP4 15.197.179.172
t=0 0
m=audio 10096 UDP/TLS/RTP/SAVPF 9 0 126
a=maxptime:150
a=mid:0
a=rtpmap:9 G722/8000
a=rtpmap:0 PCMU/8000
a=rtpmap:126 telephone-event/8000
a=fmtp:126 0-16
a=sendrecv
a=rtcp:10096
a=rtcp-mux
a=setup:active
a=fingerprint:sha-256 40:D9:FD:A2:E1:29:9C:BD:B3:5F:D5:D7:34:09:14:53:A9:1C:88:CB:39:94:FF:92:2A:04:4A:C8:50:65:4E:45
a=ptime:20
a=ice-ufrag:6qOFBFkZ
a=ice-pwd:x351JbR8XrEMETETBcNReCmAut
a=ice-options:trickle
a=candidate:p5cYCL0veNRZnoMd 1 UDP 2130706431 15.197.179.172 10096 typ host
a=end-of-candidates

INVITE sips:172.18.159.123:19306;transport=wss SIP/2.0
Via: SIP/2.0/WSS 2hv4o7vvn3as.invalid;branch=z9hG4bK8995589660000000
Max-Forwards: 69
To:
From:
Call-ID: 0m70b41666e5072839r7
CSeq: 8490 INVITE
Contact: sip:[email protected];transport=wss;ob
Content-Type: application/sdp
Allow: INVITE,ACK,CANCEL,BYE,UPDATE,MESSAGE,OPTIONS,REFER,INFO,NOTIFY
Supported: ice,replaces,outbound
User-Agent: CloudCall 1.114.212(383) EdifyWebRTC MacOS
Content-Length: 2873

v=0
o=- 8968014052079880201 4 IN IP4 127.0.0.1
s=-
t=0 0
a=extmap-allow-mixed
a=msid-semantic: WMS 58BE7B01-4C09-4284-8EA5-5306723B98F7
a=group:BUNDLE 0
m=audio 3854 UDP/TLS/RTP/SAVPF 111 63 9 102 0 8 13 110 126
c=IN IP4 67.161.105.208
a=rtpmap:111 opus/48000/2
a=rtpmap:63 red/48000/2
a=rtpmap:9 G722/8000
a=rtpmap:102 ILBC/8000
a=rtpmap:0 PCMU/8000
a=rtpmap:8 PCMA/8000
a=rtpmap:13 CN/8000
a=rtpmap:110 telephone-event/48000
a=rtpmap:126 telephone-event/8000
a=fmtp:111 minptime=10;useinbandfec=1
a=fmtp:63 111/111
a=rtcp:9 IN IP4 0.0.0.0
a=rtcp-fb:111 transport-cc
a=extmap:1 urn:ietf:params:rtp-hdrext:ssrc-audio-level
a=extmap:2 http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time
a=extmap:3 http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions-01
a=extmap:4 urn:ietf:params:rtp-hdrext:sdes:mid
a=setup:actpass
a=mid:0
a=msid:58BE7B01-4C09-4284-8EA5-5306723B98F7 3FF4234E-21F4-4396-85CE-C063956E3169
a=sendonly
a=ice-ufrag:rS1s
a=ice-pwd:uDTCqDczFATQjuVj4OS0p8vS
a=fingerprint:sha-256 08:9E:69:A9:6A:A9:34:92:76:75:7D:3D:CB:19:BC:D9:84:88:D4:22:6A:71:4C:9B:FF:DC:94:2F:C7:E5:C7:91
a=candidate:2496253636 1 udp 2122129151 172.20.20.20 65188 typ host generation 0 network-id 1 network-cost 50
a=candidate:3056440949 1 udp 2122063615 172.31.254.224 58483 typ host generation 0 network-id 6 network-cost 50
a=candidate:2109241241 1 udp 2121932543 127.0.0.1 51746 typ host generation 0 network-id 4
a=candidate:775187944 1 udp 2122262783 2601:1c2:881:6360::9203 52321 typ host generation 0 network-id 2 network-cost 50
a=candidate:2274126704 1 udp 2122197247 2601:601:510:b692:b43d:c65:44e3:515 62101 typ host generation 0 network-id 3 network-cost 50
a=candidate:627473872 1 udp 2122005759 ::1 56552 typ host generation 0 network-id 5
a=candidate:2513026274 1 udp 1685921535 67.161.105.208 3854 typ srflx raddr 172.20.20.20 rport 65188 generation 0 network-id 1 network-cost 50
a=candidate:1784879696 1 tcp 1518149375 172.20.20.20 55005 typ host tcptype passive generation 0 network-id 1 network-cost 50
a=candidate:1216824033 1 tcp 1518083839 172.31.254.224 55006 typ host tcptype passive generation 0 network-id 6 network-cost 50
a=candidate:2199036685 1 tcp 1517952767 127.0.0.1 55007 typ host tcptype passive generation 0 network-id 4
a=candidate:3500063100 1 tcp 1518283007 2601:1c2:881:6360::9203 55008 typ host tcptype passive generation 0 network-id 2 network-cost 50
a=candidate:2032582628 1 tcp 1518217471 2601:601:510:b692:b43d:c65:44e3:515 55009 typ host tcptype passive generation 0 network-id 3 network-cost 50
a=candidate:3687622980 1 tcp 1518025983 ::1 55010 typ host tcptype passive generation 0 network-id 5
a=ice-options:trickle
a=ssrc:1806953479 cname:pGnCwsP9xjzNotNE
a=ssrc:1806953479 msid:58BE7B01-4C09-4284-8EA5-5306723B98F7 3FF4234E-21F4-4396-85CE-C063956E3169
a=rtcp-mux

[✓] Flutter (Channel stable, 3.22.2, on macOS 14.3 23D56 darwin-arm64, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2024.1)
[✓] VS Code (version 1.94.2)

[mikaelwills]

I wonder if this would explain something I’m noticing with the hold work I’ve been doing.
I’ve got a hold working, then unhold, but any other hold after that fails.