Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Ability to expose native Klipper commands as buttons #1214

Open
Sineos opened this issue Oct 24, 2023 · 3 comments
Open

[FR] Ability to expose native Klipper commands as buttons #1214

Sineos opened this issue Oct 24, 2023 · 3 comments
Labels
FR - Enhancement New feature or request

Comments

@Sineos
Copy link

Sineos commented Oct 24, 2023

Is your feature request related to a problem? Please describe

Just stumbled over this example: https://klipper.discourse.group/t/internal-error-bed-screws-adjust/11159/2

I find it horrid to create a macro just to be able to display built-in Klipper commands as a button in the UI.

Describe the solution you'd like

Provide means to map built-in Klipper commands to buttons.

Describe alternatives you've considered

No response

Additional information

No response

@Sineos Sineos added the FR - Enhancement New feature or request label Oct 24, 2023
@pedrolamas
Copy link
Member

Hi @Sineos, thank you for sending this Feature Request.

I do see value in this request, though I haven't yet given proper thought on how we would go to implement this...

Nevertheless, for the specific case that the link refers, we already expose all of those directly on the Fluidd interface!

The BED_SCREWS_ADJUST is on the "Tools" menu in the Tool card:

image

Once the user clicks that, the "Bed Screws Adjust" dialog will pop up with the tool status and action buttons:

image

The dialog will only show if this option is enabled though:

image

@Sineos
Copy link
Author

Sineos commented Oct 26, 2023

Thanks for coming back to this @pedrolamas.

Yes, I'm aware of the above functionality and the initial example was not the best. I just have seen such "button macros" quite sometimes in support activities and finally thought, I just place this FR, since I think it is cluttering and "abusing" the printer.cfg for an UI inherent functionality.

Maybe a simplified version of Octoprint's Custom Controls, e.g. just a control name and an underlying command.

@pedrolamas
Copy link
Member

I wasn't aware of the OctoPrint Custom Controls, but that sure has spiked my interest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants