Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Octicon" links not visible when hovering on a heading. #265

Closed
duhrer opened this issue Apr 29, 2024 · 1 comment · Fixed by #266
Closed

"Octicon" links not visible when hovering on a heading. #265

duhrer opened this issue Apr 29, 2024 · 1 comment · Fixed by #266
Labels
bug Something isn't working

Comments

@duhrer
Copy link
Collaborator

duhrer commented Apr 29, 2024

As @amb26 pointed out on the chats, the heading "octicon" icons no longer appear on hover. I have confirmed that this is also the case when loading main locally. I have confirmed that the markdown is still there, probably it's just a matter of adjusting styles.

When working on this we should also briefly confirm whether #242 is still an issue.
@duhrer duhrer added the bug Something isn't working label Apr 29, 2024
@duhrer
Copy link
Collaborator Author

duhrer commented Apr 29, 2024

I went back through history, it looks like this has been broken since #247 was merged, which makes sense, as it removed the styles for octicons.

duhrer added a commit to duhrer/infusion-docs that referenced this issue Apr 29, 2024
@duhrer
fluid-projectGH-265: Restored 'octicons' on heading hover.
1556988
@duhrer duhrer mentioned this issue Apr 29, 2024
Merged
@jobara jobara linked a pull request Apr 29, 2024 that will close this issue
GH-265: Restore 'octicon' link on heading hover (resolves #265) #266
Merged
amb26 added a commit that referenced this issue Apr 29, 2024
@amb26
Merge branch 'GH-265' into main
8f3812f 
* GH-265:
  GH-263: Removed 'old' search dependencies and code now that pagefind is in use.
  GH-265: Restored 'octicons' on heading hover.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-265: Restore 'octicon' link on heading hover (resolves #265) duhrer/infusion-docs
1 participant
@duhrer