-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The space is left behind when the hide button slides down. #23
Comments
You can also use the 'Toggle Device toolbar' provided with Chrome DevTools to simulate mobile devices. You should check this out. |
When the site is updated with the latest version of Infusion, and UI Options (the tool you are describing now), it will switch to a mobile/small screen layout. Please see the UI Options demo for an example. In short, this issue should be addressed by updating to recent dev release of Infusion, or to a new stable version if Infusion 3.0 has been released by the time this is worked on. |
@jobara , Is UI Options demo using the latest version of infusion? |
@sachin10101998 it should be built from the latest code from the master branch. |
@jobara, @jhung, I had a doubt regarding the span of values that different UI options are providing for line spacing. In the UI Options Demo and floe project website, the line spacing values from 0.7 to 1 cause the list of elements in the table of contents to overlap ( issue described in fluid-project/floeproject.org#110). However, this issue has been solved by placing a cap on line spacing values in the feedback demo where it was solved by keeping the values of line spacing between 1 and 2. Does that mean that fluid-project/floeproject.org#110 can be solved by putting a cap on line spacing values so that it's value doesn't go below 1? |
@sachin10101998 this issue does not relate to any sort of line spacing. |
@sachin10101998 did you mean to comment on a different issue? |
Yeah, I tagged the issue I was referring to. I raised the topic here since you mentioned UI Options Demo, which has a similar problem as that issue I was referring to. |
@jobara should i close this issue or should i send a PR for this? |
Maybe you can do some preliminary investigation into how much work it would be to update to the latest dev release of Infusion from NPM. |
@jobara, isn't 2.0 latest dev release version of Infusion? |
@sachin10101998 2.0 is the latest stable release. There have been many 3.0 dev releases. If you go to https://www.npmjs.com/package/infusion and go to the "versions" tab you can see a list. You can also see this by running |
Ok @jobara . |
Describe the bug
When we resize the window by decreasing its windows width to its minimum the hide button slides down leaving the area as it was before
To reproduce
Steps to reproduce the behavior:
Expected behavior
The hide button should go down with no space leaving behind.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop
The text was updated successfully, but these errors were encountered: