Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The space is left behind when the hide button slides down. #23

Open
aashimgarg opened this issue Feb 26, 2020 · 13 comments
Open

The space is left behind when the hide button slides down. #23

aashimgarg opened this issue Feb 26, 2020 · 13 comments
Labels
bug Something isn't working

Comments

@aashimgarg
Copy link
Contributor

Describe the bug

When we resize the window by decreasing its windows width to its minimum the hide button slides down leaving the area as it was before

To reproduce

Steps to reproduce the behavior:

  1. Go to 'https://fluidproject.org/'
  2. Resize the window width to minimum.
  3. See error

Expected behavior

The hide button should go down with no space leaving behind.

Screenshots

If applicable, add screenshots to help explain your problem.
IMG_20200226_230933 (1)

Desktop

  • OS: [e.g. ubuntu 18.04]
  • Browser [e.g. chrome]
@aashimgarg aashimgarg added the bug Something isn't working label Feb 26, 2020
@sachin10101998
Copy link
Contributor

You can also use the 'Toggle Device toolbar' provided with Chrome DevTools to simulate mobile devices. You should check this out.

@jobara
Copy link
Member

jobara commented Feb 27, 2020

When the site is updated with the latest version of Infusion, and UI Options (the tool you are describing now), it will switch to a mobile/small screen layout. Please see the UI Options demo for an example. In short, this issue should be addressed by updating to recent dev release of Infusion, or to a new stable version if Infusion 3.0 has been released by the time this is worked on.

@sachin10101998
Copy link
Contributor

@jobara , Is UI Options demo using the latest version of infusion?

@jobara
Copy link
Member

jobara commented Feb 27, 2020

@sachin10101998 it should be built from the latest code from the master branch.

@sachin10101998
Copy link
Contributor

@jobara, @jhung, I had a doubt regarding the span of values that different UI options are providing for line spacing. In the UI Options Demo and floe project website, the line spacing values from 0.7 to 1 cause the list of elements in the table of contents to overlap ( issue described in fluid-project/floeproject.org#110). However, this issue has been solved by placing a cap on line spacing values in the feedback demo where it was solved by keeping the values of line spacing between 1 and 2. Does that mean that fluid-project/floeproject.org#110 can be solved by putting a cap on line spacing values so that it's value doesn't go below 1?

@aashimgarg
Copy link
Contributor Author

@sachin10101998 this issue does not relate to any sort of line spacing.

@jobara
Copy link
Member

jobara commented Feb 27, 2020

@sachin10101998 did you mean to comment on a different issue?

@sachin10101998
Copy link
Contributor

Yeah, I tagged the issue I was referring to. I raised the topic here since you mentioned UI Options Demo, which has a similar problem as that issue I was referring to.
I'd make a copy of my comment above under the appropriate issue too.

@aashimgarg
Copy link
Contributor Author

When the site is updated with the latest version of Infusion, and UI Options (the tool you are describing now), it will switch to a mobile/small screen layout. Please see the UI Options demo for an example. In short, this issue should be addressed by updating to recent dev release of Infusion, or to a new stable version if Infusion 3.0 has been released by the time this is worked on.

@jobara should i close this issue or should i send a PR for this?

@jobara
Copy link
Member

jobara commented Mar 3, 2020

Maybe you can do some preliminary investigation into how much work it would be to update to the latest dev release of Infusion from NPM.

@sachin10101998
Copy link
Contributor

@jobara, isn't 2.0 latest dev release version of Infusion?

@jobara
Copy link
Member

jobara commented Mar 4, 2020

@sachin10101998 2.0 is the latest stable release. There have been many 3.0 dev releases. If you go to https://www.npmjs.com/package/infusion and go to the "versions" tab you can see a list. You can also see this by running npm show infusion versions from the command line. The latest dev release made from master is 3.0.0-dev.20200213T130945Z.c3c22dc4c

@aashimgarg
Copy link
Contributor Author

Ok @jobara .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants