Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider refactoring browser-specific capabilities on creating a new session #16

Open
fluffysquirrels opened this issue Jan 31, 2018 · 3 comments
Open

Consider refactoring browser-specific capabilities on creating a new session #16

fluffysquirrels opened this issue Jan 31, 2018 · 3 comments

Comments

@fluffysquirrels
Copy link
Owner

fluffysquirrels commented Jan 31, 2018 •
edited
Loading

As originally discussed on PR #9.

@equalsraf wrote:

Initially I meant to set the option in the chrome driver. My question here is what to do when connecting to without the driver type. For example www can attach to a running http server without the spawning the driver.
@fluffysquirrels fluffysquirrels mentioned this issue Jan 31, 2018
Merged
fluffysquirrels referenced this issue Jan 31, 2018
@equalsraf
Request w3c compliance from chrome driver
66414dd 
By default chromedriver is NOT compliant with the w3c spec. But one
can request w3c compliance with a capability extension included in the
new session command payload.
@fluffysquirrels
Copy link
Owner Author

Good point. My use case for attaching was to re-use an existing session, which of course already had capabilities specified when it was created.

I'm not 100% happy with leaving browser-specific initialisation in, but it shouldn't hurt. I'm probably 95% happy with it :) . Maybe I'll add some comments to each driver and to each of the Chrome hacks in the shared code.

@equalsraf
Copy link
Contributor

Well this particular option is pretty tricky because it ensures chromedriver is compatible with the w3c spec. And I dont think there is any command line option to enable this globally in chrome driver.

@fluffysquirrels
Copy link
Owner Author

Yup, let's leave it in for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fluffysquirrels @equalsraf