Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with make function on page 843 #47

Open
kamalfarahani opened this issue Oct 30, 2024 · 0 comments
Open

Problem with make function on page 843 #47

kamalfarahani opened this issue Oct 30, 2024 · 0 comments

Comments

@kamalfarahani
Copy link

I believe the pseudocode for object construction on page 843 is somewhat misleading:

def make(the_class, some_arg):
    new_object = the_class.__new__(some_arg)
    if isinstance(new_object, the_class):
      the_class.__init__(new_object, some_arg)
    return new_object

Firstly, it doesn't function correctly even in the simplest case. the_class.__new__(some_arg) should be called as the_class.__new__(the_class, some_arg) for proper operation. Secondly, it lacks generality. I suggest the following code as a more suitable replacement:

def make(the_class, *args, **kwargs):
    new_object = the_class.__new__(the_class, *args, **kwargs)
    if isinstance(new_object, the_class):
        the_class.__init__(new_object, *args, **kwargs)
    return new_object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant