Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions to build Docker images #318

Closed
stevehipwell opened this issue Mar 7, 2022 · 3 comments
Closed

Use GitHub Actions to build Docker images #318

stevehipwell opened this issue Mar 7, 2022 · 3 comments
Assignees

Comments

@stevehipwell
Copy link

Using a GitHub Action workflow to build the Docker images should give more control and visibility on how the images are created. It will also allow both #313 and #314 to be implemented.

I'd suggest basing the workflow on calyptia-fluentd-docker-image but with an additional step/job to promote the tag to a GH release for tracking.

@patrick-stephens
Copy link

Seems reasonable to me, although I'd probably try to use the metadata action with Github and just push all images regardless to GHCR.io apart from possibly PRs as they'll need extra permissions on forks.
https://github.com/fluent/fluent-bit/blob/master/.github/workflows/call-build-images.yaml#L69

@ashie
Copy link
Member

ashie commented Jun 29, 2022

Another issue for Windows: #276

@ashie ashie self-assigned this Jun 29, 2022
@ashie ashie moved this to In-Progress in Fluentd Kanban Aug 1, 2022
@ashie ashie removed the status in Fluentd Kanban Aug 1, 2022
@ashie ashie removed this from Fluentd Kanban Oct 15, 2024
@kenhys
Copy link
Contributor

kenhys commented Dec 2, 2024

Recently, Automated builds on hub.docker.com feature was disabled for Docker free team, so switched to deploy with GitHub Actions.
v1.17.1-1.2 was deployed successfully with new scheme.

NOTE: #276 is out of scope in this migration.

@kenhys kenhys closed this as completed Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants