tls: improve debug information on the cause of the failure when loading system certificates on windows #9533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niedbalski
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
gives detailed information on the cause of the failure when loading system certificates. Signed-off-by: Jorge Niedbalski <[email protected]>
niedbalski
force-pushed
the
calyptia-tls-windows-certs
branch
from
8224ac0 to
7f1a65b
Compare
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gives better detailed information on the cause of the failure when loading system certificates on windows.
This patch also adds a condition to allow identifying colliding certificates (X509_R_CERT_ALREADY_IN_HASH_TABLE)
or errors while enumerating the system certificates (GetLastError() != CRYPT_E_NOT_FOUND)
This patch goes next to #9527 and #9528
Testing
This patch goes next to #9527 and #9528
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.