-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
out_doris: add new doris out plugin #9514
base: master
Are you sure you want to change the base?
Conversation
Does this need additional dependencies? |
This component has no new additional dependencies. |
Signed-off-by: composer <[email protected]>
Signed-off-by: composer <[email protected]>
Signed-off-by: composer <[email protected]>
Signed-off-by: composer <[email protected]>
Signed-off-by: composer <[email protected]>
Signed-off-by: composer <[email protected]>
Signed-off-by: composer <[email protected]>
Signed-off-by: composer <[email protected]>
Signed-off-by: composer <[email protected]>
Signed-off-by: composer <[email protected]>
It seems that msvc does not have |
Yes, you have to support all legacy targets I'm afraid so the various vendored libraries have atomic support in place. I'm not sure if there is a general way in Fluent Bit to do it @cosmo0920 ? |
We need to use InterlockedAdd in Windows for the equivalent operation of __sync_fetch_and_add. |
Signed-off-by: composer <[email protected]>
Thank you both! |
Signed-off-by: composer <[email protected]>
Could someone help me run the ci? |
@joker-star-l I've triggered it, it is limited to keep costs down and for security best practice |
Thank you! All checks are passed. |
Hello, are there any problems with this PR? |
It will be in the review queue so be patient and wait for a review. |
OK, thank you! |
Add new doris out plugin.
#9501
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
fluent-bit-docs/pull/1483
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.