in_forward: Use full width of gzip header for checking whether concatenated or not #9139
Conversation
cosmo0920
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
src/flb_gzip_concatenated.c
Outdated
| return count; | ||
| } | ||
|
|
||
| size_t flb_gzip_concatenated_borders(const char *data, size_t len, size_t **out_borders, size_t border_count) |
There was a problem hiding this comment.
since this function does pretty much the same than _count plus setting up the borders, I suggest to merge both and make **out_borders optional, e.g: if set, write the borders on it
There was a problem hiding this comment.
Thank you for your suggestion.
Fixed at dcc9ca5.
src/flb_gzip_concatenated.c
Outdated
| return FLB_FALSE; | ||
| } | ||
|
|
||
| size_t flb_gzip_concatenated_count(const char *data, size_t len) |
There was a problem hiding this comment.
rename to flb_gzip_count() and merge it on flb_gzip.c
|
CentOS 7 failure on CI will be fixed by #9157. |
|
@cosmo0920 to merge this, let's remove the number of commits since half of them are around initial implementation, so we just keep the last ones |
|
Sure, I'll concatenated into one commit. |
cosmo0920
force-pushed
the
cosmo0920-widen-gzip-border-check
branch
from
e18cc86 to
cad1bea
Compare
|
I squashed my commits into one commit. |
|
it needs to be splitted in 2 or 3 commits:
it should be:
or
|
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
cosmo0920-widen-gzip-border-check
branch
from
cad1bea to
4199737
Compare
|
I split my commit for meaningful groups of commits. |
Using for concatenated gzip conformation with magic bytes, compression method and OS flags.
Follows up for #8665.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.