Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: build: Enable kafka plugins on Windows #8662

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

cosmo0920
Copy link
Contributor

@cosmo0920 cosmo0920 commented Apr 3, 2024

In Windows, we forcibly disabled out_kafka plugin on Windows for OpenSSL linkage issues.
Nowadays, this linkage issue seems to be fixed on CI/CD.
So, I'm trying to enable this plugin on Windows.

In AppVeyor, we're able to resolve OpenSSL linkage to use vcpkg built ones.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@cosmo0920 cosmo0920 added the ok-package-test Run PR packaging tests label Apr 3, 2024
@cosmo0920 cosmo0920 force-pushed the cosmo0920-enable-out_kafka-on-windows branch from 00137c1 to 4056181 Compare April 3, 2024 07:49
@patrick-stephens
Copy link
Contributor

I would just remove AppVeyor entirely, let's not complicate CMake because of it.

@cosmo0920
Copy link
Contributor Author

Hmm..., AppVeyor CI is still alive. So, would we remove or disable AppVeyor CI from this repo?

@patrick-stephens
Copy link
Contributor

Configure it not to run for PRs or similar. I think complicating CMake for it is not a good idea here.

It may be better as a separate PR just to remove AppVeyor entirely.

@cosmo0920 cosmo0920 marked this pull request as ready for review April 15, 2024 08:25
@cosmo0920
Copy link
Contributor Author

I updated to disable almost of the AppVeyor/s CI/CD tasks. To remove this workflow or delete AppVeyor's project should be handled in the separated PR, I believe.

@patrick-stephens
Copy link
Contributor

Note, once merged we need to update the release workflow as well to ensure it does not try to pull AppVeyor binaries as this will fail now.

@cosmo0920
Copy link
Contributor Author

Hi, is this PR able to get merged? Because an article https://laurierhodes.info/node/156 was up to seek opportunity to use out_kafka plugin on Windows. We need to cover this case. :)

@cosmo0920 cosmo0920 mentioned this pull request Jul 19, 2024
7 tasks
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Jul 24, 2024
@cosmo0920 cosmo0920 removed the Stale label Jul 24, 2024
@cosmo0920 cosmo0920 force-pushed the cosmo0920-enable-out_kafka-on-windows branch from cc4430e to 0fe8e21 Compare July 24, 2024 03:04
@cosmo0920 cosmo0920 changed the title windows: build: Enable out_kafka plugin on Windows windows: build: Enable kafka plugins on Windows Jul 24, 2024
@edsiper edsiper added this to the Fluent Bit v3.1.5 milestone Aug 7, 2024
@cosmo0920 cosmo0920 force-pushed the cosmo0920-enable-out_kafka-on-windows branch 6 times, most recently from 99c9ee8 to e9c4f03 Compare August 7, 2024 06:58
@cosmo0920 cosmo0920 force-pushed the cosmo0920-enable-out_kafka-on-windows branch from e9c4f03 to 6f6831b Compare August 7, 2024 06:59
@cosmo0920
Copy link
Contributor Author

I rethought a bit and I used vcpkg to install the latest OpenSSL libraries with x86|x64-windows-static triplet.
This can resolve weird linkage errors.

@yangliuqing5470
Copy link

Can you share the compiled windows zip with kafka?

@cosmo0920
Copy link
Contributor Author

Can you share the compiled windows zip with kafka?

This will be up on the next release. Or, unstable build will bring up them if this PR is merged.

@yangliuqing5470
Copy link

Can you share the compiled windows zip with kafka?

This will be up on the next release. Or, unstable build will bring up them if this PR is merged.

OK! Thanks

@edsiper edsiper merged commit 13ea609 into master Aug 8, 2024
73 checks passed
@edsiper edsiper deleted the cosmo0920-enable-out_kafka-on-windows branch August 8, 2024 22:17
@yangliuqing5470
Copy link

There is no 3.1.5 in the installation documentation for windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required ok-package-test Run PR packaging tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants