-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows: build: Enable kafka plugins on Windows #8662
Conversation
00137c1
to
4056181
Compare
I would just remove AppVeyor entirely, let's not complicate CMake because of it. |
Hmm..., AppVeyor CI is still alive. So, would we remove or disable AppVeyor CI from this repo? |
Configure it not to run for PRs or similar. I think complicating CMake for it is not a good idea here. It may be better as a separate PR just to remove AppVeyor entirely. |
I updated to disable almost of the AppVeyor/s CI/CD tasks. To remove this workflow or delete AppVeyor's project should be handled in the separated PR, I believe. |
Note, once merged we need to update the release workflow as well to ensure it does not try to pull AppVeyor binaries as this will fail now. |
Hi, is this PR able to get merged? Because an article https://laurierhodes.info/node/156 was up to seek opportunity to use out_kafka plugin on Windows. We need to cover this case. :) |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
cc4430e
to
0fe8e21
Compare
99c9ee8
to
e9c4f03
Compare
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
e9c4f03
to
6f6831b
Compare
I rethought a bit and I used vcpkg to install the latest OpenSSL libraries with x86|x64-windows-static triplet. |
Can you share the compiled windows zip with kafka? |
This will be up on the next release. Or, unstable build will bring up them if this PR is merged. |
OK! Thanks |
There is no 3.1.5 in the installation documentation for windows |
In Windows, we forcibly disabled out_kafka plugin on Windows for OpenSSL linkage issues.
Nowadays, this linkage issue seems to be fixed on CI/CD.
So, I'm trying to enable this plugin on Windows.
In AppVeyor, we're able to resolve OpenSSL linkage to use vcpkg built ones.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.