Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter_log_to_metrics: fix log to metrics label test. #7972

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

pwhelan
Copy link
Contributor

@pwhelan pwhelan commented Sep 25, 2023

Summary

The 'label' property for the log to metrics filter was renamed to 'add_label' for consistency with the rest of the plugins. This PR updates the code to use the new property and updates the test to work with the new property name.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@pwhelan pwhelan temporarily deployed to pr September 25, 2023 19:42 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr September 25, 2023 19:42 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr September 25, 2023 19:42 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr September 25, 2023 20:16 — with GitHub Actions Inactive
@leonardo-albertovich leonardo-albertovich merged commit 36ce4b6 into master Sep 26, 2023
35 of 40 checks passed
@leonardo-albertovich leonardo-albertovich deleted the pwhelan-fix-log-to-metrics-label-test branch September 26, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants