-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filter_log_to_metrics: Fix config key after rename #7967
Conversation
e784379
to
0fdc7d0
Compare
Configuration:
|
It seems like I merged part of your change in #7972. Mind rebasing off of master so we can get the fixed log error message? |
Signed-off-by: Markus Meyer <[email protected]>
0fdc7d0
to
2b6d525
Compare
Thanks for the hint @pwhelan. Now this PR contains a change to a log message only. @cosmo0920 Feel free tom erge or close this MR as you see fit. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Closing due to inactivity. |
After #7739 was merged, the config key
label
was renamed toadd_label
in #7964.Not all occurrences of the key
label
were renamed in #7964, which leads to a regression and failing tests.This change renames the key throughout the code of the filter.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.