Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out_http: Fix bug where post_all_requests() always returns a value less than 0 #7952

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

nicehide
Copy link
Contributor

When using body_key and headers_key in output:http, post_all_requests() is called in cb_http_flush(). The exit condition of the while(ret = flb_log_event_decoder_next()) loop is stored in 'ret' and returned as is. This leads to an error being recognized in cb_http_flush(), resulting in a "failed to post requests body" error, and input tasks accumulating in a pending state, causing continuous memory consumption growth. This has been fixed.


Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • [N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@nicehide nicehide temporarily deployed to pr September 21, 2023 14:11 — with GitHub Actions Inactive
@nicehide nicehide temporarily deployed to pr September 21, 2023 14:11 — with GitHub Actions Inactive
@nicehide nicehide temporarily deployed to pr September 21, 2023 14:11 — with GitHub Actions Inactive
@nicehide nicehide temporarily deployed to pr September 21, 2023 14:39 — with GitHub Actions Inactive
@edsiper edsiper merged commit f6a48df into fluent:master Sep 21, 2023
40 of 42 checks passed
@nicehide nicehide deleted the nicehide_out_http branch September 22, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants