-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in_process_exporter_metrics: implement process exporter metrics #7943
Conversation
a15854b
to
8b7116f
Compare
@cosmo0920 I think we had a conversation around this feature but don't remember the details. Since official node exporter exposes this feature through a processes collector, why we are doing it in a separate plugin ? |
This is because the official node_exporter provides proceeses metrics as system level of process metrics. This plugin intentds to provide process level of metrics. For example, this needs to observe each of fluent-bit processes' metrics (memory, threads, cpu seconds etc). |
@cosmo0920 is there a way to filter out what metrics are collected with each process? For example, only collecting CPU / Memory for all processes? |
Currently, there is no way to filter out each of metrics with CPU, memory, threads and so on. Should we implement such feature? |
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
8b7116f
to
e86b866
Compare
I understand the requirements of filtering with the types of process metrics. I added turning on/off parameter for:
|
In the official node_exporter, process level of metrics exporter is not provided. the 3rd party exporter is provided. However, the 3rd party exporter is still not process level but for process group level of exporter.
We try to provide genuine process level of exporter in Linux.
Closes #7870
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
e.g.)
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
fluent/fluent-bit-docs#1198
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.