Implement prometheus remote write decoder #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmo0920
changed the title
cosmo0920
force-pushed
the
cosmo0920-prometheus-remote-write-decoder
branch
from
c267905 to
8cb2739
Compare
|
Thank you. Before we merge this, please add some unit tests for the decoding. e.g: https://github.com/fluent/cmetrics/tree/master/tests |
|
Got it. I supposed that Prometheus encoding and decoding pair test should be enough for now… |
…eus remote write Currently, the following types are supported: * counter * gauge * untyped Signed-off-by: Hiroshi Hatake <[email protected]>
This protobuf defitions is referred in Prometheus' commit: 033c9b229df1dbe04d4d548305befe022743b602. Signed-off-by: Hiroshi Hatake <[email protected]>
… the renewed protocol Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
…definitions Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
cosmo0920-prometheus-remote-write-decoder
branch
from
8cb2739 to
613689d
Compare
|
Oh, memory leaks are detected. I'll investigate on it. |
Signed-off-by: Hiroshi Hatake <[email protected]>
|
Now, CI gets green. 🟢 |
edsiper
requested changes
Apr 23, 2024
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
…included Signed-off-by: Hiroshi Hatake <[email protected]>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.