Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to improve usability when trying to use the nixpkgs catalog in isolated cases, an example of this being our example usage of
mkEnv
, where we have to add this passthru https://github.com/flox-examples/floxEnv/blob/31d0ce3e7d2c5f2c67903546940df7ae40ed3159/flake.nix#L9-L11 so that it can be used here https://github.com/flox-examples/floxEnv/blob/31d0ce3e7d2c5f2c67903546940df7ae40ed3159/pkgs/default.nix#L6.With this change we should be able to get rid of the passthru and write
with inputs.floxpkgs.catalogs.nixpkgs.evalCatalog;
, and without this change or the passthru we would need to change it towith inputs.floxpkgs.inputs.nixpkgs.${system}.evalCatalog;
(and acquiresystem
from somewhere too).I've spoken with @ysndr about the possibility of de-system-ing inputs of inputs, but it sounds like that would be difficult, and semantically it is weird to "abuse" floxpkgs as a way to import other things from its inputs if it isn't re-exporting them.
Not sure if this is the best format to do this in, maybe we could have
passthru.catalogs
andpassthru.evalCatalogs
separately? I actually don't know enough about them yet to know what the difference is.