Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PS/2 doesn't properly handle errors from the controller #28

Open
Gegy opened this issue Dec 15, 2017 · 3 comments
Open

PS/2 doesn't properly handle errors from the controller #28

Gegy opened this issue Dec 15, 2017 · 3 comments
Assignees
@Gegy
Labels
bug
Milestone
0.2.0

Comments

@Gegy
Copy link
Member

Gegy commented Dec 15, 2017 •
edited
Loading

This causes the kernel to freeze (panics, and we have no logger for that) when an error is thrown, as it just calls .expect() on the Result.
@Gegy Gegy added the bug label Dec 15, 2017
@Gegy Gegy self-assigned this Dec 15, 2017
@Restioson
Copy link
Member

I assume this will be fixed in the ps2 rework? @gegy1000

@Gegy
Copy link
Member Author

Gegy commented Mar 5, 2018

@Restioson Yep.

@Restioson Restioson added this to the 0.2.0 milestone Mar 26, 2018
@Gegy Gegy closed this as completed May 6, 2018
@Gegy Gegy reopened this May 6, 2018
@Gegy
Copy link
Member Author

Gegy commented May 6, 2018

Whoops. This can only be closed along with the ps2-enhancement merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gegy Gegy

Labels
bug
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
2 participants
@Gegy @Restioson