Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect declaration of virtual function makes project not compilable with float type #475

Open
shumi12321 opened this issue Jun 2, 2020 · 4 comments · May be fixed by #476
Open

Incorrect declaration of virtual function makes project not compilable with float type #475

shumi12321 opened this issue Jun 2, 2020 · 4 comments · May be fixed by #476

Comments

@shumi12321
Copy link

fcl/include/fcl/math/motion/interp_motion.h

Line 79 in ff83249

bool integrate(double dt) const;

This bug prevents building FCL types with float. Declaration of this function should not take double as argument, but templated type S.
@shumi12321
Copy link
Author

Also, here you are missing forward declaration for float:
https://github.com/flexible-collision-library/fcl/blob/master/include/fcl/math/motion/interp_motion-inl.h#L48

@sherm1
Copy link
Member

sherm1 commented Jun 2, 2020

Thanks @shumi12321 -- can you submit a PR to fix this?

@shumi12321
Copy link
Author

Hi @sherm1 , I creted following PR:
#476

@shumi12321 shumi12321 linked a pull request Jun 3, 2020 that will close this issue
Open
@sherm1
Copy link
Member

sherm1 commented Jun 3, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed issue with creating instances of type InterpMotion<float> shumi12321/fcl
2 participants
@sherm1 @shumi12321