Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing template instantiation of conservativeAdvancement for RSS/OBBRSS #297

Open
geoynomous opened this issue Jun 3, 2018 · 0 comments · May be fixed by #300
Open

Missing template instantiation of conservativeAdvancement for RSS/OBBRSS #297

geoynomous opened this issue Jun 3, 2018 · 0 comments · May be fixed by #300

Comments

@geoynomous
Copy link
Contributor

It uses the instantiation of with const BVHModel<BV>&,

but then this is used as node

MeshConservativeAdvancementTraversalNode<BV> node;

and not

MeshConservativeAdvancementTraversalNodeRSS<BV> node; or
MeshConservativeAdvancementTraversalNodeOBBRSS<BV> node;

The two later one works thread-safe while the previous one does not as its initialize refits the tree.
geoynomous added a commit to geoynomous/fcl that referenced this issue Jun 3, 2018
@geoynomous
add missing template instantiation for conservativeAdvancement
4916672 
Now partial template instantiation are available for RSS/OBBRSS
which resemble the situation of 0.5.0 where

MeshConservativeAdvancementTraversalNodeRSS/OBBRSS are used and not
MeshConservativeAdvancementTraversalNode

The later refitting the whole tree, while the former two only work with
transformations locally stored in the node.

Refactors code to avoid duplication

resolves flexible-collision-library#297
@geoynomous geoynomous mentioned this issue Jun 3, 2018
Closed
geoynomous added a commit to geoynomous/fcl that referenced this issue Jun 3, 2018
@geoynomous @eberberich
add missing template instantiation for conservativeAdvancement
245a7ab 
Now partial template instantiation are available for RSS/OBBRSS
which resemble the situation of 0.5.0 where

MeshConservativeAdvancementTraversalNodeRSS/OBBRSS are used and not
MeshConservativeAdvancementTraversalNode

The later refitting the whole tree, while the former two only work with
transformations locally stored in the node.

Refactors code to avoid duplication

resolves flexible-collision-library#297
@geoynomous geoynomous mentioned this issue Jun 3, 2018
Closed
geoynomous added a commit to geoynomous/fcl that referenced this issue Jun 3, 2018
@geoynomous
add missing template instantiation for conservativeAdvancement
4ab4d7d 
Now partial template instantiation are available for RSS/OBBRSS
which resemble the situation of 0.5.0 where

MeshConservativeAdvancementTraversalNodeRSS/OBBRSS are used and not
MeshConservativeAdvancementTraversalNode

The later refitting the whole tree, while the former two only work with
transformations locally stored in the node.

Refactors code to avoid duplication

resolves flexible-collision-library#297
@geoynomous geoynomous linked a pull request Jun 3, 2018 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@geoynomous