Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Window fullscreen on mobile devices and web #3620

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Window fullscreen on mobile devices and web #3620

wants to merge 3 commits into from
+23 −2

Conversation

bl1nch
Copy link
Contributor

@bl1nch bl1nch commented Jul 9, 2024 •
edited by sourcery-ai bot
Loading

Summary by Sourcery

This pull request introduces fullscreen mode support for mobile devices and web by integrating the fullscreen_window package. It updates the fullscreen logic to conditionally use this package for non-desktop platforms and adds the necessary dependency to the pubspec.yaml file.

  • New Features:
    • Added support for fullscreen mode on mobile devices and web using the fullscreen_window package.
  • Enhancements:
    • Updated the logic to conditionally use the fullscreen_window package for non-desktop platforms.
  • Build:
    • Added fullscreen_window package to the project dependencies.

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Jul 9, 2024 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request adds fullscreen functionality for mobile devices and web. It introduces the 'fullscreen_window' package and updates the windowFullScreen logic to use 'FullScreenWindow.setFullScreen' for non-desktop platforms.

File-Level Changes

Files Changes
packages/flet/lib/src/controls/page.dart
packages/flet/pubspec.yaml		 Implemented fullscreen functionality for mobile devices and web by adding 'fullscreen_window' package and updating the windowFullScreen logic.
Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

sourcery-ai[bot]
sourcery-ai bot reviewed Jul 9, 2024
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bl1nch - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@ndonkoHenri
Copy link
Contributor

ndonkoHenri commented Jul 9, 2024 •
edited
Loading

Please always make sure to fill the PR template, when you open a PR.
Can you please explain what your PR does? (a screen capture will be appreciated)

@bl1nch
Copy link
Contributor Author

bl1nch commented Jul 9, 2024 •
edited
Loading

Please always make sure to fill the PR template, when you open a PR. Can you please explain what your PR does? (a screen capture will be appreciated)

This PR should provide fullscreen mode for Android, IOS and WEB platforms. On Android and IOS, if fullscreen mode is active, the system status bar is hidden; on WEB, the tab simply goes into fullscreen mode

@FeodorFitsner
Copy link
Contributor

Thanks for your PR. fullscreen_window implementation for web still uses dart:html which prevents compiling to WASM. Should be converted to use package:web.

@FeodorFitsner
Copy link
Contributor

I've created upstream issue: jakky1/fullscreen_window#4

@FeodorFitsner
Copy link
Contributor

Need investigating. On web it enters into fullscreen mode and then immediately exits.

@bl1nch
Copy link
Contributor Author

bl1nch commented Nov 26, 2024 •
edited
Loading

Need investigating. On web it enters into fullscreen mode and then immediately exits.

Same on Android. But the default example at https://pub.dev/packages/fullscreen_window#example works fine

@ndonkoHenri ndonkoHenri linked an issue Dec 13, 2024 that may be closed by this pull request
Fullscreen Support hiding the System bar and Navigation bar on Mobile #4551
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@FeodorFitsner FeodorFitsner FeodorFitsner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fullscreen Support hiding the System bar and Navigation bar on Mobile
3 participants
@bl1nch @ndonkoHenri @FeodorFitsner