-
-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Clean up examples #1545
Comments
We probably should remove it, but the question comes as do we want to add it back with the plugin behind the scenes? We shouldn't really be 'advertising' plugins as our own work/part of fleaflet.
Do you think it should be removed then? If that's what the CRS is (confusing), then that's what it is, if you see what I mean. My experience with CRSs other than the normal Mercator (etc) is very limited.
For me, it appears to be instant, if there was no snackbar already displayed. Showing the coords in a snackbar was probably a mistake (due to its slow update time), so we should probably find a different way of showing it.
When running on the web and using the Chrome DevTools > Network > Throttling > Offline, I actually get a different error in the snackbar, and it happens instantly for me:
In terms of a more descriptive error we could return, I'm not sure what that might be. If there's no connection, that's the issue - but sometimes it appears as a
We're aware that this has been broken, and we assume it broke with the
I think it's working as it's supposed to be.
We display it on the front page on startup, and wherever the attribution needs to be different. Looking at the more in-depth guidelines at https://wiki.osmfoundation.org/wiki/Licence/Attribution_Guidelines, we meet the requirements. The
In summary; Things to do for sure:
Still open questions:
|
I think it makes sense to have some custom CRS examples, my example (EPSG:3413) displays some tricky edge cases in that CRS to prevent bugs I've previously fixed from reoccurring over time. Then again they could be tests instead, but sometimes it also helps to have a visual presentation. As for EPSG4326 specifically, I don't know how useful it is. If we decide to keep it we might try to get tiles that are better suited for that projection perhaps, at least with respect to the labels, and zoom the example in on a point where the distortion of the map itself isn't as apparent as it is when fully zoomed out. Could be less confusing. |
Ah, also, regarding:
Since we are already keeping a list of plugins in the docs, we could probably delegate the responsibility of plugin usage to the plugins themselves? Less maintenance on our end. What I'm suggesting is simply removing the animations page from the examples might be sufficient. |
Welp, I've got another 2 weeks of exams coming up, but afterward I might get some time to get round to all of this - anyone else feel free to jump in in the meantime! |
|
I think plugins should not be used in the example app for a couple of reasons:
So I agree that we should just remove the animated map example and let users rely on the documentation for finding plugins. We could even suggest that plugin authors tag their plugins with flutter-map or flutter-map-plugin to help users find plugins on pub.dev. I'm going to have a look at making some of the changes suggested in this issue (nice job on cataloging them all @JosefWN ). |
I've opened a PR to address some of these changes, so far it removes the animated MapController and fixed the TileLayer reload. Some comments: I think these probably deserve a separate issue:
For examples which are confusing and/or not useful for users I think we should:
|
What do you want implemented?
pages/animated_map_controller.dart
which provides a poorer solution?Invalid argument(s): No host specified in URI
in flight mode, which seems a bit cryptic. Failed DNS lookup? Perhaps we should return a more informative error to the library user, not just in the example but in general. Nit: Sometimes these UI notifications, just like the ones in the secondary tap example, load quite a bit later than when the event occurs (i.e. when I pan without internet connection, tiles fail to load, and after a number of seconds, I get the message).What other alternatives are available?
No response
Can you provide any other information?
No response
Severity
Minimum: Not required for my use
The text was updated successfully, but these errors were encountered: