Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use MakeMakefile.find_executable in place of MiniPortile#which #96

Open
flavorjones opened this issue Feb 21, 2021 · 1 comment
Open

Comments

@flavorjones
Copy link
Owner

MiniPortile currently has a private methods, which, that searches the $PATH environment variable for an executable, and makes sure to do it safely on Windows as well as POSIX systems.

But Ruby's MakeMakefile module has a method find_executable that does the same thing. Let's use that instead and delete some code.

@stanhu
Copy link
Contributor

stanhu commented Jul 17, 2023

find_executable emits a message to stdout (checking for X) every time it's called: https://github.com/ruby/ruby/blob/f302e725e10ae05e613e2c24cae0741f65f2db91/lib/mkmf.rb#L1637

Is that an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants