Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition options undocumented, possibly broken #22

Open
su opened this issue Oct 6, 2014 · 2 comments
Open

Transition options undocumented, possibly broken #22

su opened this issue Oct 6, 2014 · 2 comments

Comments

@su
Copy link

su commented Oct 6, 2014

The feature was merged here from @siamkreative back in March.

  1. They're undocumented.
  2. They call for classnames, but need them specified differently from the existing features, eg. closeButtonClass calls for the format ".classname" but the transition options need the class without the leading period or it also gets inserted into the element class attribute.
  3. Using transitionIn or transitionOut individually is fine, but if you specify both of them, the close button(specified with closeButtonClass) no longer works, for no reason I can figure out. (I don't have time at the moment to dig into this.)
@su su changed the title Transition opens remain undocumented Transition options remain undocumented Oct 6, 2014
@su su changed the title Transition options remain undocumented Transition options undocumented, possibly broken Oct 6, 2014
@siamkreative
Copy link
Contributor

Feel free to create a pull request for everything you mentioned :) I'll try to look at it but I'm pretty busy at the time.

Cheers

@siamkreative
Copy link
Contributor

I added a quick demo: #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants