Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document Since for FileChooser #1146

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

A6GibKm
Copy link
Contributor

@A6GibKm A6GibKm commented Oct 11, 2023

These options were added since version 3 of this interface.

@GeorgesStavracas
Copy link
Member

Why are you bumping the interface version to 4?

@A6GibKm
Copy link
Contributor Author

A6GibKm commented Oct 11, 2023

Because they are new methods.

@GeorgesStavracas
Copy link
Member

Please document it in the commit message in details then

@A6GibKm
Copy link
Contributor Author

A6GibKm commented Oct 11, 2023

These are the commits since v3

71165a5 * docs: Add current_folder option to the OpenFile method
70e5d91 * docs: Update the description of paths as byte arrays
70d87b3 * filechooser: Support current_folder with OpenFile
0a082d7 *   Merge pull request #226 from matthiasclasen/clarify-file-filters
        |\  
28f482d | * Clarify the docs on filters in the file chooser
b907d57 * | Fix typos in FileChooser doc
35fca7f * | FileChooser: Add a 'current_filter' return value
00b28db * | Bump the version of the file chooser interface

These options were added since version 3 of this interface. These are
the relevant commits after 00b28db where it was bumped to v3.

71165a5  docs: Add current_folder option to the OpenFile method
35fca7f  FileChooser: Add a 'current_filter' return value
00b28db  Bump the version of the file chooser interface
@A6GibKm
Copy link
Contributor Author

A6GibKm commented Oct 11, 2023

Done.

@GeorgesStavracas GeorgesStavracas added this pull request to the merge queue Oct 26, 2023
Merged via the queue into flatpak:main with commit 4bf4d63 Oct 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug portal: file chooser File Chooser portal
Projects
Status: Triaged
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants