Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flat-manager-client should reattach to an in-progress job rather than failing #7

Open
abderrahim opened this issue Mar 3, 2019 · 4 comments

Comments

@abderrahim
Copy link
Contributor

After being killed (for instance because of #2) running flat-manager-client with --wait complains the the build is already committed even though the commit is still in progress.

It would be nice if it could still wait for the running job to finish (and if possible, print its output).

@nanonyme
Copy link
Contributor

nanonyme commented Mar 3, 2019

If this behaviour isn't 1:1 desirable for Flathub app builds, there could always be a separate parameter for us to use.

@alexlarsson
Copy link
Member

I don't think re-running it the same way and doing something else is right, but we should have a way to just connect to and wait for a running job.

@nanonyme
Copy link
Contributor

nanonyme commented Mar 4, 2019

How do we know though if the commit succeeds or not if backend may return garbage?

@alexlarsson
Copy link
Member

Well, the garbage response is just a temporary network issue. You can reconnect to the service and get the status of the job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants