Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for nterms > 1 #37

Open
lgarrison opened this issue Aug 29, 2024 · 0 comments
Open

support for nterms > 1 #37

lgarrison opened this issue Aug 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@lgarrison
Copy link
Member

It would be good to have support for multi-sinusoid fits; i.e. nterms > 1. The default Astropy implementation is here: https://github.com/astropy/astropy/blob/bf1103e5061d4a13c928afcaa66865154f5d9afe/astropy/timeseries/periodograms/lombscargle/implementations/fastchi2_impl.py

It uses many trig_sum() calls, which finufft replaces, so there may be a good speedup opportunity there.

Relevant to #34.
@lgarrison lgarrison added the enhancement New feature or request label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lgarrison