-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Type 3? #3
Comments
Hi folks, I wanted to bump this to see if there was any interest in having this feature added? I've found the Type 3 transform in finufft extremely useful and would love to have autodiff capabilities of that function. Thanks! |
Thanks @tyler-a-cox! It's great to know that you have a use case. One question, how important is GPU support? AFAIK, there still isn't any GPU support for Type 3 transforms (@lgarrison, @ahbarnett - is that right?). I'm happy to chat through what a CPU implementation would take, but I'm probably currently too over-committed to dedicate much coding time myself right now! |
It's true that GPU type 3 is some way off (maybe this summer?). I also would like to know use-cases for that (eg MRI uses t1 and t2) to understand how to prioritize that. However, wrapping t3 CPU would be not too hard a generalization of t1, since the source derivatives are similar, but you need to add target derivs too (as in a t2). Much easier project than understanding how the t3 works :) PS Leslie & I recently realized |
Thanks for the responses, @dfm and @ahbarnett! I'm personally interested in using the type 3 transform for simulating radio interferometric measurements. The sources and measurements are often not gridded, requiring us to use the type 3 transform. On CPU alone, we've found that our implementation with the type 3 is an order of magnitude or two faster than our existing simulator, under certain circumstances. We would definitely be interested in a GPU implementation in the future, but for now the CPU implementation would be very useful! I will take a look at what was done for the type 1 and 2 transforms and see if I can get a CPU implementation running. Thanks again for the help! |
There aren't currently any plans to support the Type 3 transform for a few reasons:
cuFINUFFT
doesn't seem to support Type 3.Do we want to work around these issues?
The text was updated successfully, but these errors were encountered: