Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions to improve workflow usability #11

Closed
2 of 3 tasks
DavidHerreros opened this issue May 30, 2024 · 4 comments
Closed
2 of 3 tasks

Suggestions to improve workflow usability #11

DavidHerreros opened this issue May 30, 2024 · 4 comments
Assignees
Labels

Comments

@DavidHerreros
Copy link
Collaborator

DavidHerreros commented May 30, 2024

  • Adding a label indicating the execution order to the tutorial notebooks (for example, 1_tutorial_preprocessing, 2_distribution_to_distribution...)

  • Instead of hardcoding paths in the jupyter notebooks, we could provided a simple "folder/file browser" window so that the user can inspect and easiliy select the desired location on his machine. Most likely, the implementation of this windows will lead to at least one extra dependency (PyQt, TK)

  • Implementing a virtualized "Plotting" class to unified the plots across the notebooks and improve mantainability of the code. See issue plotting notebook (map2map dist2dist results) #18

@geoffwoollard
Copy link
Collaborator

I would definitely do #1, with the suggested numbering of
1_tutorial_preprocessing.ipynb, 2_tutorial_svd.ipynb, 3_tutorial_map2map.ipynb, 4_tutorial_distribution2distribution.ipynb

@geoffwoollard
Copy link
Collaborator

I don't know how to do #2, but @DavidHerreros , could you implement that for one of the notebooks and we can see how it works?

@geoffwoollard
Copy link
Collaborator

I will keep #3 in mind when I make the plotting functionality for the distribution to distribution results. I think it makes sense for there to be plotting functionality synced up with the results (e.g. certain plots for svd, other plots for the map2map results, and still other plots for the dist2dist results).

@geoffwoollard
Copy link
Collaborator

Issue #18 subsumes plotting scope of this issue. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants