Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #84 and #85 #90

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix #84 and #85 #90

wants to merge 7 commits into from

Conversation

elad
Copy link

@elad elad commented Dec 17, 2014

Adds support for setting default value and allow union types with a format.

@jcrugzz
Copy link
Member

jcrugzz commented Dec 22, 2014

@elad would you mind rebasing off of master? (just to double check 0.8 even though its probably fine)

@elad
Copy link
Author

elad commented Dec 23, 2014

Yep, done.

@jcrugzz
Copy link
Member

jcrugzz commented Dec 23, 2014

@elad I should have mentioned this earlier but a test case for this would be awesome :). Otherwise this LGTM

@elad
Copy link
Author

elad commented Dec 23, 2014

Sure, I'll follow up when I get a chance to look into it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants