Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genesis block hard fork timestamps are ignored #20

Open
awfm9 opened this issue Feb 26, 2022 · 1 comment
Open

Genesis block hard fork timestamps are ignored #20

awfm9 opened this issue Feb 26, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@awfm9
Copy link
Contributor

awfm9 commented Feb 26, 2022

A lot of code on the Avalanche / Flare side of things (meaning not the Coreth side) ignores the hard fork timestamps from the genesis block, and only uses the hard-coded timestamps. This means that staging / local testing of hard forks is impossible for code on the Flare side.

@awfm9 awfm9 added the bug Something isn't working label Feb 26, 2022
@awfm9 awfm9 self-assigned this Feb 26, 2022
@awfm9
Copy link
Contributor Author

awfm9 commented Feb 27, 2022

We should probably report this upstream. The issue is that the genesis block, containing the timestamps for the hard forks, is only decoded inside of the EVM. This means that the timestamps from the genesis block are not available from within the core Avalanche code.

I worked around this for debugging by allowing to override the hard fork timestamps with environment variables for non-standard networks, but that's not something that is clean enough to add it to a release, imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant