From 97e9acbdf4ff5aecf58a74ff6734891aad3668ec Mon Sep 17 00:00:00 2001
From: Maina Wycliffe <wmmaina7@gmail.com>
Date: Thu, 6 Jun 2024 09:40:10 +0300
Subject: [PATCH] fix: Config changes - reset page to 1 when filters change

Fixes #2007
---
 .../Configs/Insights/Filters/ConfigInsightsFilters.tsx          | 2 +-
 src/pages/config/ConfigChangesPage.tsx                          | 2 +-
 src/pages/config/ConfigInsightsList.tsx                         | 2 +-
 src/pages/config/details/ConfigDetailsChangesPage.tsx           | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/components/Configs/Insights/Filters/ConfigInsightsFilters.tsx b/src/components/Configs/Insights/Filters/ConfigInsightsFilters.tsx
index ec819afe6..7ffc3262a 100644
--- a/src/components/Configs/Insights/Filters/ConfigInsightsFilters.tsx
+++ b/src/components/Configs/Insights/Filters/ConfigInsightsFilters.tsx
@@ -10,7 +10,7 @@ type ConfigInsightsFiltersProps = {
 };
 
 export function ConfigInsightsFilters({
-  paramsToReset = ["pageIndex", "pageSize"]
+  paramsToReset = ["pageIndex"]
 }: ConfigInsightsFiltersProps) {
   return (
     <FormikFilterForm
diff --git a/src/pages/config/ConfigChangesPage.tsx b/src/pages/config/ConfigChangesPage.tsx
index bbfab951d..06d81019c 100644
--- a/src/pages/config/ConfigChangesPage.tsx
+++ b/src/pages/config/ConfigChangesPage.tsx
@@ -187,7 +187,7 @@ export function ConfigChangesPage() {
           ) : (
             <>
               <ConfigChangeFilters
-                paramsToReset={["pageIndex", "pageSize"]}
+                paramsToReset={["page"]}
                 arbitraryFilters={arbitraryFilter}
               />
               <ConfigChangeHistory
diff --git a/src/pages/config/ConfigInsightsList.tsx b/src/pages/config/ConfigInsightsList.tsx
index 92b0d7e5d..fc34932ec 100644
--- a/src/pages/config/ConfigInsightsList.tsx
+++ b/src/pages/config/ConfigInsightsList.tsx
@@ -59,7 +59,7 @@ export function ConfigInsightsPage() {
       >
         <ConfigPageTabs activeTab="Insights">
           <div className="flex flex-row items-center">
-            <ConfigInsightsFilters paramsToReset={["pageIndex", "pageSize"]} />
+            <ConfigInsightsFilters paramsToReset={["pageIndex"]} />
           </div>
           <div className="flex flex-col h-full overflow-y-hidden">
             <ConfigInsightsList
diff --git a/src/pages/config/details/ConfigDetailsChangesPage.tsx b/src/pages/config/details/ConfigDetailsChangesPage.tsx
index f3b953f97..fe4d73b25 100644
--- a/src/pages/config/details/ConfigDetailsChangesPage.tsx
+++ b/src/pages/config/details/ConfigDetailsChangesPage.tsx
@@ -131,7 +131,7 @@ export function ConfigDetailsChangesPage() {
     >
       <div className={`flex flex-col flex-1 h-full overflow-y-auto`}>
         <div className="flex flex-col flex-1 items-start gap-2 overflow-y-auto">
-          <ConfigRelatedChangesFilters />
+          <ConfigRelatedChangesFilters paramsToReset={["page"]} />
           <div className="flex flex-col flex-1 overflow-y-auto">
             <ConfigChangeHistory
               linkConfig={!hideConfigColumn}