Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uniquely identifying configs by external id #708

Closed
adityathebe opened this issue Jul 9, 2024 · 0 comments · Fixed by #742
Closed

uniquely identifying configs by external id #708

adityathebe opened this issue Jul 9, 2024 · 0 comments · Fixed by #742
Assignees
Labels
bug Something isn't working

Comments

@adityathebe
Copy link
Member

adityathebe commented Jul 9, 2024

fix source vertex not found error by namespacing all look ups to the scraper.

The source vertex not found error would occur only in cases where multiple clusters were being scraped. The lookups needed to be scoped to the given scraper.

Example: When forming a Namespace default -> Deployment Nginx relationship for cluster A, the lookup for external id Kubernetes/Namespace//default would return the ID of the default namespace from cluster B. This would cause failure when forming the graph as the edge couldn't be inserted since there's no source vertex in the graph.

resolves: #703

@adityathebe adityathebe added the bug Something isn't working label Jul 9, 2024
@adityathebe adityathebe self-assigned this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant