Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit-test-kind option to allow choosing bin or lib #322

Merged
merged 1 commit into from
May 16, 2024

Conversation

felipou
Copy link
Contributor

@felipou felipou commented May 15, 2024

When running with the unit-test option, there was no way to choose between a bin or lib target, so the result was always an error if there were both types for the same target name. To allow running unit tests in that case, this new option unit-test-kind may be used to specify the type of target that we want.

@felipou
Copy link
Contributor Author

felipou commented May 15, 2024

Partially solves #245 (partially because we're not choosing "lib" automatically, the solution requires a new command line option, but at least allows us to run in that scenario, which was the problem I was having).

Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable, thanks!

src/bin/cargo-flamegraph.rs Outdated Show resolved Hide resolved
When running with the unit-test option, there was no way to choose
between a bin or lib target, so the result was always an error if
there were both types for the same target name. To allow running
unit tests in that case, this new option unit-test-kind may be used
to specify the type of target that we want.
@djc djc merged commit 512f20c into flamegraph-rs:main May 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants