Add support for profiling unit-test style benchmarks #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to pass in an iterator to the build() function, it just constrains how the object can be for no real benefit. Just provide a Vec. Signed-off-by: Daniel Müller <[email protected]>
Clippy has a few things to complain about. Address the "issues". Signed-off-by: Daniel Müller <[email protected]>
This change extends the program with support for profiling unit test benchmarks, aka libtest benchmarks. Support is accomplished in a vein similar to that of unit tests: we introduce the --unit-bench argument that behaves very much like the existing --unit-test does, but invokes benchmarks instead of tests. We cannot piggy-back on the existing --bench argument for the same reason (presumably) that --unit-test is separate from --test: --bench and --test require a target to be provided, but --unit-test and --unit-bench can work without an argument or can be a pattern of tests to match against, but not a target. Closes: #275 Signed-off-by: Daniel Müller <[email protected]>
djc
reviewed
Aug 8, 2023
| unit_bench: Some(Some(t)), | ||
| .. | ||
| } => { | ||
| trailing_arguments.push("--bench".to_string()); |
There was a problem hiding this comment.
What is this trying to achieve? It seems like a weird setup to append to a copy of trailing_arguments.
There was a problem hiding this comment.
One runs benchmarks with the --bench switch provided to the unit test binary. See <binary> --help. We were already doing a copy a few lines down, so this doesn't really change much.
Yes. |
djc
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extends the program with support for profiling unit test
benchmarks, aka libtest benchmarks. Support is accomplished in a vein
similar to that of unit tests: we introduce the
--unit-benchargumentthat behaves very much like the existing
--unit-testdoes, but invokesbenchmarks instead of tests.
We cannot piggy-back on the existing
--benchargument for the samereason (presumably) that
--unit-testis separate from--test:--benchand
--testrequire a target to be provided, but--unit-testand--unit-benchcan work without an argument or can be a pattern of teststo match against, but not a target.