-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OMP_NUM_THREADS discouraged? Why? #825
Comments
@zerothi Thanks for your feedback. The following scenarios you provided
do indeed reflect how BLIS response to those environment variables. First, the library checks
I understand and appreciate your perspective. You may have already thought of this, but let me explain why I personally prefer that users use a BLIS-specific environment variable: it forces the user to consciously know what they are getting. What I don't like about reading Let me know if you have any other questions. |
I guess I should add that none of the devs currently have any plans to deprecate |
Sure. I'm fine with removing the language about potential deprecation if that's what is bothering @zerothi. |
Indeed.
I am not advocating removing the
This was actually my goal here ;) |
Removed description of possible deprecation of OMP_NUM_THREADS. After discussion in flame#825 it was agreed to: - lax the deprecation warning, OMP_NUM_THREADS will always be a fall-bock. - Clarified with a simple example on how to do different regions of thread-counts. Signed-off-by: Nick Papior <[email protected]>
I am reading your wiki pages with comments on environment variables. Then I stumble upon:
https://github.com/flame/blis/blob/master/docs/Multithreading.md#environment-variables-the-automatic-way
Quote:
Now, while I can see that having dedicated environment variables for the project, I think this goes largely against the end-user base.
At least from my perspective I do this:
However, here comes the problem. When BLIS is compiled with OpenMP support, I would very much like to be able to tell our users about
OMP_NUM_THREADS
, as a first entry point to play with threading/parallelism.This is the de-facto standard for end-users, and also the other related OMP flags,
OMP_PLACES
,OMP_PROC_BIND
.I would like the hierarchy to be simple:
In this way, users won't be troubled by odd naming conventions that means nothing to them.
PS. I know that fine-tuning the other BLIS specific env's is necessary, but most users won't bother with these details.
The text was updated successfully, but these errors were encountered: