From 4ff5975bc1f184c5333e7fc640ff9006f4dad49a Mon Sep 17 00:00:00 2001 From: Melissa Alvarez Date: Mon, 12 Feb 2024 11:54:58 -0700 Subject: [PATCH] [ML] Data Frame Analytics functional tests: ensure job state is stopped before attempting to create custom url (#176622) ## Summary Fixes https://github.com/elastic/kibana/issues/164224 Extends timeout to wait for job to be in 'stopped' state before attempting to create custom url. Flaky test run https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5120 ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> --- .../functional/apps/ml/data_frame_analytics/custom_urls.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/x-pack/test/functional/apps/ml/data_frame_analytics/custom_urls.ts b/x-pack/test/functional/apps/ml/data_frame_analytics/custom_urls.ts index 17f07c0d26297..ab1b46796dad4 100644 --- a/x-pack/test/functional/apps/ml/data_frame_analytics/custom_urls.ts +++ b/x-pack/test/functional/apps/ml/data_frame_analytics/custom_urls.ts @@ -38,8 +38,7 @@ export default function ({ getService }: FtrProviderContext) { const ml = getService('ml'); const browser = getService('browser'); - // FLAKY: https://github.com/elastic/kibana/issues/164224 - describe.skip('custom urls', function () { + describe('custom urls', function () { const dfaJobId = `fq_regression_${Date.now()}`; const generateDestinationIndex = (analyticsId: string) => `user-${analyticsId}`; let testDashboardId: string | null = null; @@ -74,7 +73,7 @@ export default function ({ getService }: FtrProviderContext) { await ml.testResources.createDataViewIfNeeded('ft_farequote', '@timestamp'); await ml.testResources.setKibanaTimeZoneToUTC(); await ml.securityUI.loginAsMlPowerUser(); - await ml.api.createAndRunDFAJob(dfaJobConfig); + await ml.api.createAndRunDFAJob(dfaJobConfig, 3 * 60 * 1000); }); after(async () => {