From 32300e7c6b03f876ffb7b70d61e3cac096fb4317 Mon Sep 17 00:00:00 2001
From: Andreas Kling <andreas.kling@bioquant.uni-heidelberg.de>
Date: Tue, 20 Aug 2024 12:00:00 +0200
Subject: [PATCH] Use correct labels and i18n in where item component

---
 .../aql-builder-where-item.component.html              | 10 +++++-----
 src/assets/i18n/de.json                                |  4 +++-
 src/assets/i18n/en.json                                |  4 +++-
 3 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/src/app/modules/aqls/components/aql-builder-where-item/aql-builder-where-item.component.html b/src/app/modules/aqls/components/aql-builder-where-item/aql-builder-where-item.component.html
index 95d050756..fb77e5069 100644
--- a/src/app/modules/aqls/components/aql-builder-where-item/aql-builder-where-item.component.html
+++ b/src/app/modules/aqls/components/aql-builder-where-item/aql-builder-where-item.component.html
@@ -4,7 +4,7 @@
   </div>
 
   <mat-form-field appearance="outline" class="input num-tiny-input operator-select">
-    <mat-label id="label">Operator</mat-label>
+    <mat-label>{{ 'LOGICAL_OPERATOR' | translate }}</mat-label>
     <mat-select
       [attr.aria-label]="'LOGICAL_OPERATOR' | translate"
       [(value)]="item.comparisonOperator"
@@ -27,9 +27,9 @@
       class="input num-tiny-input value-input"
       *ngIf="item.isParameterType"
     >
-      <mat-label id="label">Parametername</mat-label>
+      <mat-label id="label">{{ 'PARAMETER_NAME' | translate }}</mat-label>
       <input
-        aria-labelledby="label"
+        [attr.aria-label]="'PARAMETER_NAME' | translate"
         type="text"
         matInput
         formControlName="value"
@@ -51,9 +51,9 @@
     class="num-tiny-input parameter-select"
     *ngIf="dialogMode === aqlBuilderDialogMode.AqlEditor"
   >
-    <mat-label id="label">Parameter</mat-label>
+    <mat-label>{{ 'PARAMETER' | translate }}</mat-label>
     <mat-select
-      [attr.aria-label]="'LOGICAL_OPERATOR' | translate"
+      [attr.aria-label]="'PARAMETER' | translate"
       [(value)]="item.isParameterType"
       data-test="aqb__where__item__is-parameter__selector"
     >
diff --git a/src/assets/i18n/de.json b/src/assets/i18n/de.json
index 4c4dade3a..930e5559f 100644
--- a/src/assets/i18n/de.json
+++ b/src/assets/i18n/de.json
@@ -199,7 +199,9 @@
   "SELECT_A_EHR_TEMPLATE": "Bitte wählen Sie mindestens 1 Rückgabeparameter",
   "MAIN_GROUP": "Hauptgruppe",
   "SUB_GROUP": "Untergruppe",
-  "LOGICAL_OPERATOR": "Logischer Operator",
+  "LOGICAL_OPERATOR": "Operator",
+  "PARAMETER": "Parameter",
+  "PARAMETER_NAME": "Parametername",
   "COMMENTS": "Kommentare",
   "WRITE_COMMENT": "Kommentar schreiben",
   "LEAVE_COMMENT": "Hinterlassen Sie hier einen Kommentar, um Ihre Gedanken mitzuteilen",
diff --git a/src/assets/i18n/en.json b/src/assets/i18n/en.json
index 50fef94db..cfa4e039b 100644
--- a/src/assets/i18n/en.json
+++ b/src/assets/i18n/en.json
@@ -198,7 +198,9 @@
   "SELECT_A_EHR_TEMPLATE": "Please select at least 1 Return Parameter",
   "MAIN_GROUP": "Maingroup",
   "SUB_GROUP": "Subgroup",
-  "LOGICAL_OPERATOR": "Logical operator",
+  "LOGICAL_OPERATOR": "Operator",
+  "PARAMETER": "Parameter",
+  "PARAMETER_NAME": "Parameter name",
   "COMMENTS": "Comments",
   "WRITE_COMMENT": "Write comment",
   "LEAVE_COMMENT": "Leave a comment here to share your thoughts",